Require Dimension to provide both name and value

amazon-archives / k8s-cloudwatch-adapter

An implementation of Kubernetes Custom Metrics API for Amazon CloudWatch

Apache License 2.0

158 stars 98 forks source link

Require Dimension to provide both name and value #74

Open ericlarssen-wf opened 3 years ago

ericlarssen-wf commented 3 years ago

Currently it is possible to create an instance of the CRD that has a dimension in which a name is provided but not a value. This should probably be caught in validation prior to being written to the kube api. Currently, the behaviour of this is to no-op which is then on the user to catch by hand.