search

amazon-archives / k8s-cloudwatch-adapter

An implementation of Kubernetes Custom Metrics API for Amazon CloudWatch
Apache License 2.0
158 stars 98 forks source link

apiextensions.k8s.io/v1beta1 apiVersion removed on k8s v1.22.0 #88

Open lspecian-olx opened 3 years ago

lspecian-olx commented 3 years ago

Description The apiextensions.k8s.io/v1beta1 apiVersion used in the CustomResourceDefinition was removed on k8s v1.22.0

Importance The issue is a blocker to install the chart properly on k8s clusters with version v1.22.0

Location

https://github.com/awslabs/k8s-cloudwatch-adapter/blob/master/charts/k8s-cloudwatch-adapter-crd/templates/crd.yaml#L1

Suggestions for an improvement I suggest the issue should be fixed by checking the apiVersion with .Capabilities.APIVersions.Has

{{- if .Capabilities.APIVersions.Has "apiextensions.k8s.io/v1" }} apiVersion: apiextensions.k8s.io/v1 {{- else }} apiVersion: apiextensions.k8s.io/v1beta1 {{- end }}