Various pull request applied and update all dependencies

amazon-archives / kinesis-storm-spout

Kinesis spout for Storm

Other

106 stars 64 forks source link

Various pull request applied and update all dependencies #37

Closed christiangda closed 7 years ago

christiangda commented 7 years ago

List of changest

applied PR #6 (manually)
applied PR #12 (manually)
applied PR #23 (manually)
applied PR #32 (manually)
partial applied PR #29 (Register MDC key for TOPOLOGY_NAME) (manually)
added Maven Encoding default to properties in pom.xml
added gitignore rules
updated all dependencies versions in pom.xml

abshkd commented 7 years ago

no one is maintaining this project anymore, it seems AWWS abandoned storm. I cant find a single working example for Storm 1.x. Any help is appreciated.

christiangda commented 7 years ago

Hi @abshkd , yes as you say!, no one is maintaining this project anymore, but my PR work with the sample describe here:

https://github.com/awslabs/kinesis-storm-spout/blob/master/src/main/samples/SampleTopology.java

pfifer commented 7 years ago

I'm looking into merging this, but don't have an immediate ETA.

christiangda commented 7 years ago

Hi pfifer!, thanks for your help, The comunity is in nedded.

I'm refactoring my PR, because I'm having problems with curator version, and I Thought that was PR #12

abshkd commented 7 years ago

@christiangda You might want to try this instead https://github.com/apache/storm/tree/master/external/storm-kinesis This is better because it matches the curator used in storm. I have it working with very minor issues at the moment. Will post example on Monday. Edit: Its the same sources btw . only merged with minor changes. Even though the source is in master or 2.x branch you can successfully use it in 1.x. I can confirm that