Await Firehose resource creation until FirehoseToS3Policy is attached…

amazon-archives / realworld-serverless-application

This project is inspired by the design and development of the AWS Serverless Application Repository - a production-grade AWS service. Learn how AWS built a production service using serverless technologies.

Apache License 2.0

515 stars 108 forks source link

Await Firehose resource creation until FirehoseToS3Policy is attached… #57

Closed Nxtra closed 4 years ago

Nxtra commented 4 years ago

When following the guide on aws blogs one might not be able to deploy the application.

The FirehoseS3Role does not have the right permissions when it tries to deploy the Firehose. To be sure the permission are correct we have to wait with deploying the Firehose resource until the correct policy is created and attached.

honglu commented 4 years ago

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

honglu commented 4 years ago

Thanks for finding the issue and submitting the PR!

honglu commented 4 years ago

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository