search

amazon-archives / sql-jdbc

🔍 Open Distro for Elasticsearch JDBC Driver
Apache License 2.0
111 stars 49 forks source link

Adding missing Elasticsearch type `object` #45

Closed abbashus closed 4 years ago

abbashus commented 4 years ago

Issue : #44

Description of changes: Added missing Elasticsearch type : object.

Note: Reviewers please verify the parameters for the enum. I believe it should be (JDBCType.STRUCT, String.class, Integer.MAX_VALUE, 0, false).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dai-chen commented 4 years ago

Please add UT for getTypeInfo and verify the impact by tool like DbVisualizer or another UT/IT that queries an object field.

abbashus commented 4 years ago

Please add UT for getTypeInfo and verify the impact by tool like DbVisualizer or another UT/IT that queries an object field.

Built a new driver jar with changes and tested via DBVisualizer that object tyep metadata is showing up.

Screen Shot 2020-01-10 at 12 50 06 PM

dai-chen commented 4 years ago

Please add UT for getTypeInfo and verify the impact by tool like DbVisualizer or another UT/IT that queries an object field.

Built a new driver jar with changes and tested via DBVisualizer that object tyep metadata is showing up.

Screen Shot 2020-01-10 at 12 50 06 PM

Thanks!