amazon-braket / Braket.jl

Experimental Julia implementation of the Amazon Braket SDK
Apache License 2.0
98 stars 7 forks source link

fix: fix inputs bug in launch_batch and add more tests #47

Closed kshyatt-aws closed 1 year ago

kshyatt-aws commented 1 year ago

Issue #, if available:

N/A

Description of changes:

Discovered a bug related to passing a vector of input dictionaries when launching a batch of tasks. Fixed that and added a variety of tests.

Testing done:

Tests pass locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Base: 93.75% // Head: 94.87% // Increases project coverage by +1.12% :tada:

Coverage data is based on head (32764d0) compared to base (59885f7). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #47 +/- ## ========================================== + Coverage 93.75% 94.87% +1.12% ========================================== Files 33 33 Lines 3827 3828 +1 ========================================== + Hits 3588 3632 +44 + Misses 239 196 -43 ``` | [Impacted Files](https://codecov.io/gh/awslabs/Braket.jl/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [src/qubit\_set.jl](https://codecov.io/gh/awslabs/Braket.jl/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c3JjL3F1Yml0X3NldC5qbA==) | `96.07% <100.00%> (+19.60%)` | :arrow_up: | | [src/task\_batch.jl](https://codecov.io/gh/awslabs/Braket.jl/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c3JjL3Rhc2tfYmF0Y2guamw=) | `92.95% <100.00%> (+8.67%)` | :arrow_up: | | [src/observables.jl](https://codecov.io/gh/awslabs/Braket.jl/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c3JjL29ic2VydmFibGVzLmps) | `97.33% <0.00%> (+0.66%)` | :arrow_up: | | [src/task.jl](https://codecov.io/gh/awslabs/Braket.jl/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c3JjL3Rhc2suamw=) | `96.42% <0.00%> (+5.05%)` | :arrow_up: | | [src/gates.jl](https://codecov.io/gh/awslabs/Braket.jl/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c3JjL2dhdGVzLmps) | `97.67% <0.00%> (+10.46%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.