amazon-braket / Braket.jl

Experimental Julia implementation of the Amazon Braket SDK
Apache License 2.0
97 stars 6 forks source link

fix: Support arbitrary angle Molmer-Sorenson gate. #62

Closed kshyatt-aws closed 11 months ago

kshyatt-aws commented 11 months ago

Issue #, if available: N/A

Description of changes: change MS gate to support 3 angles.

Testing done: Unit tests passed locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 11 months ago

Codecov Report

Patch coverage: 43.47% and project coverage change: -0.05% :warning:

Comparison is base (d1cd7e8) 95.76% compared to head (8b8aa82) 95.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #62 +/- ## ========================================== - Coverage 95.76% 95.71% -0.05% ========================================== Files 35 35 Lines 4039 4040 +1 ========================================== - Hits 3868 3867 -1 - Misses 171 173 +2 ``` | [Files Changed](https://app.codecov.io/gh/awslabs/Braket.jl/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [src/gate\_applicators.jl](https://app.codecov.io/gh/awslabs/Braket.jl/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c3JjL2dhdGVfYXBwbGljYXRvcnMuamw=) | `72.97% <9.09%> (ø)` | | | [src/gates.jl](https://app.codecov.io/gh/awslabs/Braket.jl/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c3JjL2dhdGVzLmps) | `93.33% <70.00%> (-1.34%)` | :arrow_down: | | [src/raw\_schema.jl](https://app.codecov.io/gh/awslabs/Braket.jl/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c3JjL3Jhd19zY2hlbWEuamw=) | `94.57% <100.00%> (-0.19%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.