amazon-braket / Braket.jl

Experimental Julia implementation of the Amazon Braket SDK
Apache License 2.0
98 stars 7 forks source link

change: Use `BraketSimulator.jl` in examples, strip out unnecessary `PyBraket.jl` components #84

Closed kshyatt-aws closed 3 months ago

kshyatt-aws commented 4 months ago

Issue #, if available: N/A

Description of changes: Now that BraketSimulator.jl exists, we can use that in examples where appropriate. This also means we only need PyBraket.jl for jobs results unpickling and interfacing with the "braket_ahs" local simulator, so we can remove a lot of extraneous logic from that subpackage.

Testing done: Unit tests passed locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 89.05%. Comparing base (1d05da0) to head (5ec3f39).

Files Patch % Lines
PyBraket/src/local_simulator.jl 55.55% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #84 +/- ## ========================================== - Coverage 90.38% 89.05% -1.33% ========================================== Files 39 36 -3 Lines 4356 3929 -427 ========================================== - Hits 3937 3499 -438 - Misses 419 430 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kshyatt-aws commented 4 months ago

Blocked on BraketSimulator.jl registration going through