amazon-braket / BraketSimulator.jl

Apache License 2.0
9 stars 3 forks source link

fix: Fix indexing to use 1-based and use proper type in tests #9

Closed kshyatt-aws closed 2 months ago

kshyatt-aws commented 2 months ago

Issue #, if available: N/A

Description of changes: The Julia wrapper around Python lists is PyList. In the tests, we were constructing a raw Python list (which has type Py) and passing it to the extension method. This PR tightens up the acceptable types in the extension method and fixes the indexing.

Testing done: Unit tests passed locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

kshyatt-aws commented 2 months ago

Tested this with my local install of amazon-braket-simulator-v2-python and its unit tests passed too. To do the same edit juliapkg.json and make rev="ksh/index_fix".

codecov[bot] commented 2 months ago

The author of this PR, kshyatt-aws, is not an activated member of this organization on Codecov. Please activate this user on Codecov to display this PR comment. Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations. Please don't hesitate to email us at support@codecov.io with any questions.