Closed Altanali closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
a9808f3
) to head (8620b84
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closing - Moving AHS Device Validation to the BDK instead of extending the default-simulator repo.
Issue #, if available:
Description of changes: Extend the AHS Validator by introducing a DeviceCapabilitiesConstants data class and additional Device-AtomArrangement, LocalDetuning, Hamiltonian, and DrivingField validators for information that's available in AWS AHS devices (e.g. Quera Aquila).
Testing done:
Testing done to achieve full coverage.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.