amazon-braket / amazon-braket-pennylane-plugin-python

A plugin for allowing Xanadu PennyLane to use Amazon Braket devices
https://amazon-braket-pennylane-plugin-python.readthedocs.io/
Apache License 2.0
43 stars 37 forks source link

feature: Persist circuits and tasks in batch execute #270

Open rmshaffer opened 3 months ago

rmshaffer commented 3 months ago

Issue #, if available:

255

Description of changes: Starting with the changes from #260 and performing the additional work required to merge to main.

In particular, we need to:

Testing done: tox

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (7cfecb8) to head (03fe023). Report is 11 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #270 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 7 7 Lines 1211 1243 +32 Branches 295 306 +11 ========================================= + Hits 1211 1243 +32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yitchen-tim commented 3 months ago

circuit is not compatible to batch_execute(). circuits is more general, when using execute() instead of batch_execute() , circuits can just return a list with one circuit. Going down this route, we can have circuit and circuits coexist, but put circuit on a deprecation path.