amazon-braket / amazon-braket-pennylane-plugin-python

A plugin for allowing Xanadu PennyLane to use Amazon Braket devices
https://amazon-braket-pennylane-plugin-python.readthedocs.io/
Apache License 2.0
43 stars 38 forks source link

feat: Support `SProd` and `CompositeOp` for expval #275

Closed speller26 closed 2 months ago

speller26 commented 2 months ago

Issue #, if available:

253

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (b154dce) to head (15012c2). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #275 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 7 7 Lines 1242 1244 +2 Branches 305 302 -3 ========================================= + Hits 1242 1244 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

speller26 commented 2 months ago

@astralcai Feel free to check if this implementation makes sense.

astralcai commented 2 months ago

Since it's passing PL integration tests I say it's good.