amazon-braket / amazon-braket-sdk-python

A Python SDK for interacting with quantum devices on Amazon Braket
https://aws.amazon.com/braket/
Apache License 2.0
294 stars 118 forks source link

fix: iterative variable assignments in AutoQASM #930

Closed rmshaffer closed 3 months ago

rmshaffer commented 3 months ago

Issue #, if available: https://github.com/amazon-braket/amazon-braket-sdk-python/issues/929, https://github.com/amazon-braket/amazon-braket-sdk-python/issues/933

Description of changes: Ensure that AutoQASM variables which are updated after declaration, including iteratively in a loop, are initialized properly.

Testing done: Added tests for new cases. Updated existing tests where variable declaration order changed. tox passes.

Note: If a variable is initialized with a Python variable and then updated iteratively in a loop, this scenario still does not work with the changes in this PR. A new issue has been added to the backlog for this: https://github.com/orgs/amazon-braket/projects/2/views/1?pane=issue&itemId=58435320.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (61ae9dd) to head (8fb3359).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/autoqasm #930 +/- ## ================================================== Coverage 100.00% 100.00% ================================================== Files 170 170 Lines 10495 10502 +7 Branches 2248 2249 +1 ================================================== + Hits 10495 10502 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.