Closed ashlhans closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
04d8a95
) to head (7930cb1
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Why remove
measure_all
functionality? If it's already released, wouldn't that be a breaking change?
@speller26, this shouldn't remove the qiskit measure_all
functionality since that function measures each qubit individually behind the scenes (ie. for a 2 qubit circuit measure_all()
is actually measure(0, 0)
and measure(1, 1)
)
This would remove the already released measure()
in the BDK but there are no examples that would break. There was some confusion with measure()
without parameter, specifically whether that would measure all qubits or only currently used qubits. To prevent that confusion, we can make the target_qubit args required.
Issue #, if available:
Description of changes:
The Circuit
measure
methodtarget_qubits
are not required.Changes
target_qubits
are now required and there is nomeasure_all()
equivalentapply_readout_noise
gets added right after the last measure instruction instead of the very end of the circuit.Testing done:
tox
andtox -e integ-tests
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.