Closed king-p3nguin closed 1 month ago
@peterkomar-aws Thank you for reviewing! I made the change based on your review.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
d5dfbf4
) to head (8ccd0ac
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @king-p3nguin , all tests are passing, there is only a minor test coverage degradation (see the coverage report). Can you add a test that covers L110 of the analog_hamiltonian_simulation module?
@peterkomar-aws Thank you for reporting. It seems like the pattern
in DrivingField
is always "uniform"
, so I removed the static method _field_or_time_series_from_ir()
and just set TimeSeries
for the DrivingField
. Let me know if it is okay or not.
Issue #, if available:
971
Description of changes:
braket.ahs.AnalogHamiltonianSimulation.from_ir()
was implemented.Testing done:
Input:
Output:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.