search

amazon-braket / amazon-braket-sdk-python

A Python SDK for interacting with quantum devices on Amazon Braket
https://aws.amazon.com/braket/
Apache License 2.0
300 stars 118 forks source link

infra: add pr_title_check workflow #991

Closed math411 closed 3 months ago

math411 commented 4 months ago

Issue #, if available:

Description of changes: This is to check the title follows the contributing guidelines Braket has laid out.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (90f9395) to head (ad7ae96). Report is 36 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #991 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 135 135 Lines 8949 8949 Branches 2011 2011 ========================================= Hits 8949 8949 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

speller26 commented 3 months ago

Is there a way to enforce this for the commit name rather than the PR? Since that's what actually matters for release purposes.

math411 commented 3 months ago

Is there a way to enforce this for the commit name rather than the PR? Since that's what actually matters for release purposes.

Had an offline discussion with @speller26 regarding this. Under the squash merge in Github settings, the commit message was moved from default to use PR title.