amazon-braket / amazon-braket-sdk-python

A Python SDK for interacting with quantum devices on Amazon Braket
https://aws.amazon.com/braket/
Apache License 2.0
294 stars 118 forks source link

fix: Error when FreeParameters are named QASM types #999

Closed Tarun-Kumar07 closed 2 weeks ago

Tarun-Kumar07 commented 3 weeks ago

Issue: Fixes #603

Description of changes:

Testing done: Unit test has been added.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Tarun-Kumar07 commented 3 weeks ago

I have raised another PR #268 in amazon-braket-pennylane-plugin-python to address the CI failure. I am not sure how to link both the PRs and make the CI pass here.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (bc56429) to head (c02785b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #999 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 135 135 Lines 8943 8949 +6 Branches 2009 2011 +2 ========================================= + Hits 8943 8949 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Tarun-Kumar07 commented 3 weeks ago

Hi, I'm not sure why the Dependent tests are failing for Windows with the following error message:

Downloading pyasn1-0.6.0-py2.py3-none-any.whl (85 kB)
---------------------------------------- 85.3/85.3 kB 5.0 MB/s eta 0:00:00
ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
unknown package:
Expected sha256 78c11785eaa1047ac2e4746c86286f6629df0289e73616ce052a82761e1de678
Got 9b0b6b23c2fc6f8ab474a12cf5cf5bb991be24ed66bab91d74bce36462ea70fd

Can someone help?

Thanks!

rmshaffer commented 3 weeks ago

Hi, I'm not sure why the Dependent tests are failing for Windows with the following error message:

I think this must have been some intermittent error downloading from PyPI. I'm re-running the failed tests and they appear to be succeeding now.

Tarun-Kumar07 commented 3 weeks ago

Hi @rmshaffer , is this PR ready to be merged ?

Tarun-Kumar07 commented 3 weeks ago

Hi @rmshaffer , can this be merged to main so that #603 can be closed :).