amazon-braket / autoqasm

AutoQASM is an experimental module offering a new quantum-imperative programming experience in Python for developing quantum programs.
Apache License 2.0
15 stars 9 forks source link

fix: multi-dimensional ArrayVar declaration #25

Closed rmshaffer closed 5 months ago

rmshaffer commented 5 months ago

Issue #, if available:

13, follow-up to PR #22

Description of changes: Fix implementation and test for multi-dimensional ArrayVar declaration.

Testing done: tox passes.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (90c2bbd) to head (4914208). Report is 13 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #25 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 43 43 Lines 1906 1907 +1 Branches 320 320 ========================================= + Hits 1906 1907 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rmshaffer commented 5 months ago

@Yash-10 please take a look if you can, this is a quick follow-up to your PR #22.

Yash-10 commented 5 months ago

Thanks, @rmshaffer, for these changes and for fixing the small issue from my PR! I think this makes more sense.