amazon-connect / amazon-connect-chat-interface

Amazon Connect Chat Interface - a browser-based customer chat widget for your website integrating with Amazon Connect ChatJS
https://docs.aws.amazon.com/connect/latest/adminguide/what-is-amazon-connect.html
MIT No Attribution
33 stars 35 forks source link

update Node LTS versions in CI workflow #121

Closed spencerlepine closed 1 year ago

spencerlepine commented 1 year ago

Issue #, if available:

Description of changes: Update Node LTS versions in CI workflow. Follow streams: https://github.com/amazon-connect/amazon-connect-streams/blob/master/.github/workflows/release.yml

- node: [10.x, 12.x, 14.x, 15.x]
+ node: [14.x, 16.x, 18.x, 19.x]

Why? master branch had recent issues running npm i and npm release in node 15/16. Following Node LTS support

since npm 8.3, the official way to handle vulnerabilities of subdependencies with npm is to use the overrides attributes: docs: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides ref: https://github.com/rogeriochaves/npm-force-resolutions/issues/56#issuecomment-1161425697

Before

Screenshot 2023-03-31 at 9 12 18 AM

After

Screenshot 2023-03-31 at 10 52 12 AM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.