amazon-connect / amazon-connect-salesforce-scv

This repository contains resources, examples, and projects to help Service Cloud Voice customers address some common requirements as they deploy Service Cloud Voice.
Apache License 2.0
52 stars 53 forks source link

Drop unrequired CloudFormation parameters from VMX2 stack #110

Closed magnetikonline closed 2 years ago

magnetikonline commented 2 years ago

Issue #, if available: N/A

Description of changes:

I noted this typo in a deployed instance of this stack:

VMXContactFlowStack:
  Type: AWS::CloudFormation::Stack
  Properties:
    Parameters:
      ConnectInstanceAlias: !Ref ConnectInstanceAlias
      ConnectInstanceARN: !Ref ConnectInstanceARN
      EnableVMToConnectTask: !Ref EnableVMToConnectTask
      EnableVMToEmail: !Ref EnableVMToEmail
      EnableVMToSalesforceCase: !Ref EnableVMToSalesforceCase
      EnableVMToSalesforceCustomObject: !Ref EnableVMToSalesforceCustomObject
      EXPTemplateVersion: !Ref EXPTemplateVersion
      SalesforceCallbackPhoneField: !Ref SalesforceCallbackPhoneField
      SalesforceContactAttributesField: !Ref SalesforceContactAttributesField
      SalesforceVoicemailLinkField: !Ref SalesforceVoicemailLinkField
      VMTestAgentId: !Ref VMTestAgentId
      VMTestQueueARN: !Ref VMTestQueueARN
      VMToEmailDefaultFrom: !Ref VMToEmailDefaultFrom
      VMToEmailDefaultTo: !Ref VMToEmailDefaultFrom

Note the double up/typo of VMToEmailDefaultFrom.

So once digging in - determined that this parameter, plus a few others aren't actually used by the nested stack. So have cleaned them up/removed them.

Also noted the AWSEmailEnabled Condition isn't used in the contact flows stack.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

magnetikonline commented 2 years ago

Ping @dougjaso 🎉

dougjaso commented 2 years ago

I intentionally have them there for future use and have no desire to remove them.

magnetikonline commented 2 years ago

Not a problem @dougjaso - but the original bug still remains - I've cut that out into #113 on it's own.