search

amazon-ion / ion-c

A C implementation of Amazon Ion.
https://amazon-ion.github.io/ion-docs/
Apache License 2.0
166 stars 43 forks source link

Update ion_debug_has_tracing to support strict function prototypes #342

Closed drakumus closed 3 months ago

drakumus commented 3 months ago

Issue 341

Description of changes: Updates ion_debug_has_tracing declaration and definition to have a void parameter. This allows projects with strict prototyping enabled to include ion-c.

nirosys commented 3 months ago

Looks like tests failed for a couple of unrelated issues. Node20 is now default, which links to a newer version of glibc than is available on amazonlinux:1 & 2. The MacOS build failed, due to Xcode 14 being removed from the runner image.

I'll follow up after this PR to fix the builds, but they have nothing to do with this PR.

The ubuntu build & tests passed, and I've verified build and test on MacOS:

[==========] 2973 tests from 42 test suites ran. (459 ms total)
[  PASSED  ] 2973 tests.
$ git plog -1
* d305818 (HEAD, drakumus/master) Update ion_debug_has_tracing to support strict function prototypes
$ uname -a
Darwin 147dda5e5395.ant.amazon.com 22.6.0 Darwin Kernel Version 22.6.0: Mon Apr 22 20:54:28 PDT 2024; root:xnu-8796.141.3.705.2~1/RELEASE_X86_64 x86_64

Going to approve and merge! Thank you @drakumus!