search

amazon-ion / ion-c

A C implementation of Amazon Ion.
https://amazon-ion.github.io/ion-docs/
Apache License 2.0
166 stars 43 forks source link

Fix amazonlinux 1 & 2 builds #345

Closed nirosys closed 3 months ago

nirosys commented 3 months ago

Issue #, if available: n/a

Description of changes: GitHub has changed the default nodejs used for actions to node20, which requires a more recent glibc than amazonlinux 1 & 2 have. This PR uses GH provided env variables to force the runner to use node16 which will work with amazonlinux 1 & 2.

Amazon Linux 2 was supposed to be EOL'd a year ago, but support was extended until June of 2025. Amazon Linux 1 has been EOL'd since Jan 1st 2024, after also being extended.

Node16 will probably be removed from the GHA runner before Amazon Linux 2 is EOL'd, so we'll have to determine if we can work around it, or if we should just move everything over to Amazon Linux 2023.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nirosys commented 3 months ago

Added an issue (#346) to give some TLC to Amazon Linux versions in our workflows.