Closed desaikd closed 5 months ago
As per an offline discussion, there is a possible solution for generated code testing without the need to create code-gen-core
. Retracting the workspace set up PR, will open up a separate PR that introduces the new solution for generated code's testing.
Issue #88:
Description of changes:
This PR includes the first prerequisites of #88. This PR adds some bug fixes for the generated code.
List of changes:
code-gen-core
.is_root_type
inCodeGenerator
, this will be used for stepping in for root and type for consecutive calls just callingnext
. (Note: This will be removed once we have Lazy Reader APIs)AbstractDataType::Struct
that will be used by template to check if the generated struct is closed or can contain open content. (Note: This just sets up the parameter to the enum but is not yet being used by template, those changes will arrive in later PRs.)Field
entry that is used by template now stores the ISL type name as that will be used to determine calling read/write_sym/string, blob/clob etc.Tests:
Still uses the older tests in
ion-cli
but will be refactored in following PRs to use new roundtrip tests.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.