search

amazon-ion / ion-dotnet

A .NET implementation of Amazon Ion.
https://amazon-ion.github.io/ion-docs/
Other
56 stars 31 forks source link

Does not support POCO serialisation #121

Open fmannhardt opened 4 years ago

fmannhardt commented 4 years ago

The readme indicates that I could serialise any POCO object using:

//Serialize an object to byte array
byte[] ionBytes = IonSerialization.Binary.Serialize(experiment);

However, I cannot find the class IonSerialization.

dhhoang commented 4 years ago

It seems like the serialization features have been excluded from the 1.0 release: https://github.com/amzn/ion-dotnet/releases/tag/v1.0.0 Someone should update the README file.

Is there any plan to support this feature in the upcoming release? This is useful for a lot of .NET users.

tgregg commented 4 years ago

Yes, we removed this API for the 1.0 release to reduce the API surface area. If there is enough demand for it, it could be added in a future release.

For now, I will update the readme to avoid the confusion.

adrianiftode commented 4 years ago

I would like to dump a bunch of objects into a Ledger database and I'm thinking a POCO serializer would help. Is there a timeline for adding this feature back?

dhhoang commented 4 years ago

I am also having an use case where this is feature is needed. @tgregg what are the steps required to implement & test this one?

tgregg commented 4 years ago

@dhhoang We need to resurrect the code from this branch: https://github.com/amzn/ion-dotnet/tree/bench-and-serialization-projects

It can be submitted as a PR with its associated tests. Once we've reviewed and merged it, we can create a new release that includes it.

ChiefInnovator commented 2 years ago

I really like this project but without the POCO serialization, it is almost useless for general adoption.

tgregg commented 2 years ago

@ChiefInnovator The following library may help! https://github.com/amzn/ion-object-mapper-dotnet/