search

amazon-ion / ion-element-kotlin

IonElement is an immutable in-memory representation of the Ion data format. IonElement's API is idiomatic to Kotlin.
Apache License 2.0
8 stars 8 forks source link

Explicitly specify return types for 3 public functions #66

Closed dlurton closed 2 years ago

dlurton commented 2 years ago

This is just a little API cleanup.

Most importantly, createIonElementLoader used to have its return type implicitly defined and by accident it was IonElementLoaderImpl when it should have been IonElementLoader.

The return types of the other functions were implicitly AnyElement, but this should be explict for best practices, so I specified their return types as well.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 2 years ago

Codecov Report

Merging #66 (5cc0ab6) into master (9237271) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage     86.70%   86.70%           
  Complexity      368      368           
=========================================
  Files            30       30           
  Lines           737      737           
  Branches         72       72           
=========================================
  Hits            639      639           
  Misses           65       65           
  Partials         33       33
Impacted Files Coverage Δ
src/com/amazon/ionelement/api/IonElementLoader.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9237271...5cc0ab6. Read the comment docs.