Closed R-maan closed 4 years ago
Do we expect these tests to hit new codepaths in the unmarshal code that we can't hit with a text reader? My assumption (hope?) was that the marshal/unmarshal code would be agnostic of the underlying reader/writer implementation (whether text, binary, or third-party implementation of the interfaces) and so the text reader is effectively a convenient way to mock the reader interface.
Hi @fernomac , these tests are not hitting new codepaths, however, when we were adding binary tests to Marshal, it let us to iron out some issues we have not found before, such as #101, #107 and #108. These tests are to give us more confident on that regard.
Expand unit testing on Unmarshal - Ion binary test data