amazon-ion / ion-go

A Go implementation of Amazon Ion.
https://amazon-ion.github.io/ion-docs/
Apache License 2.0
174 stars 31 forks source link

Error messages should not start with a capital letter or end in punctuation #131

Closed zslayton closed 4 years ago

zslayton commented 4 years ago

@fernomac just informed me on another PR that:

per https://github.com/golang/go/wiki/CodeReviewComments#error-strings error strings in go should not start with a capitalized word or end in punctuation

Sorry, I know this was my suggested text. 🤦 Rather than fixing this here, I think we should make a cleanup issue to fix this project-wide before a 1.0 release.

Originally posted by @zslayton in https://github.com/amzn/ion-go/pull/128