search

amazon-ion / ion-go

A Go implementation of Amazon Ion.
https://amazon-ion.github.io/ion-docs/
Apache License 2.0
175 stars 31 forks source link

Implement AnnotationsAsSymbols #153

Closed justing-bq closed 4 years ago

justing-bq commented 4 years ago

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Dependent on https://github.com/amzn/ion-go/pull/146

codecov-commenter commented 4 years ago

Codecov Report

Merging #153 into master will decrease coverage by 0.25%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   76.74%   76.48%   -0.26%     
==========================================
  Files          25       25              
  Lines        5370     5388      +18     
==========================================
  Hits         4121     4121              
- Misses        743      761      +18     
  Partials      506      506
Impacted Files Coverage Δ
ion/reader.go 59.86% <0.00%> (-0.80%) :arrow_down:
ion/symboltoken.go 80.00% <0.00%> (-8.14%) :arrow_down:
ion/writer.go 54.90% <0.00%> (-13.40%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1e45452...858d96d. Read the comment docs.

justing-bq commented 4 years ago

Closed PR because annotations API changes are being overhauled in https://github.com/byronlin-bq/ion-go/pull/6.