adds a fix for timestamp fractional seconds that have positive exponent

amazon-ion / ion-go

A Go implementation of Amazon Ion.

https://amazon-ion.github.io/ion-docs/

Apache License 2.0

175 stars 31 forks source link

Closed desaikd closed 3 years ago

desaikd commented 3 years ago

Issue #180

Description of changes: This PR works on fixing an issue with timestamp fractional seconds that has positive exponent value.

Changes:

Added a condition to check for negative scale value with 0 coefficient for fractional seconds.
Added binary reader test for fractional seconds with positive exponent.

cc @byronlin13 @justing-bq

justing-bq commented 3 years ago

LGTM

byronlin13 commented 3 years ago

Did you test this fix against Ion hash go?

LGTM

desaikd commented 3 years ago

Did you test this fix against Ion hash go?

LGTM

Yes, I have tested this with ion-hash-go and it passes all the tests.