search

amazon-ion / ion-intellij-plugin

Support for Ion in Intellij IDEA.
Apache License 2.0
28 stars 22 forks source link

Support formatting for Idea 2023 #49

Closed QwerTech closed 1 year ago

QwerTech commented 1 year ago

Issue #, if available: https://github.com/amazon-ion/ion-intellij-plugin/issues/48

Description of changes: Added IonFormattingModelBuilder for IC-231 the same as it was for IC-222 which solves the issue for Idea 2023 when Reformat Code in Ion file is executed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

popematt commented 1 year ago

Thanks for contributing this. I'm taking a look at the PR, but I will likely not be able to finish today because I need to gather some context to understand this change.

peddiashrith commented 1 year ago

Hi, can you please let us know when will this fix be deployed to stable channel?

peddiashrith commented 1 year ago

I am still facing the below issue when I was trying to install the latest release v2.3.0 Plugin 'Amazon Ion' (version '2.3.0+7-IC-2022.2') is not compatible with the current version of the IDE, because it requires build 223.* or older but the current build is IU-231.9011.34

linlin-s commented 1 year ago

Hi, thanks for the comment, we will start investigating and get back to you soon.

QwerTech commented 1 year ago

This change only fixed formatting for Idea 2023 and the plugin installed from Beta channel. But moving the plugin to the stable channel for 2023 Idea should be done in a separate Pull request.