Closed popematt closed 1 week ago
Attention: Patch coverage is 75.18797%
with 33 lines
in your changes missing coverage. Please review.
Please upload report for BASE (
ion-11-encoding@4b373e5
). Learn more about missing BASE report.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issue #, if available:
None.
Description of changes:
EE
op code.A0
for "unknown symbol" to60
and90
for empty symbol to75
.@Disabled
annotation from disabled tests inIonManagedWriter_1_1_Test
IonTypeID
. (I.e. wasSYMBOL(1)
, now0xEE(SYMBOL,1)
) That was useful to me while debugging things.EncodingDirectiveCompilationTest
. For some reason, I couldn't seem to understand how these tests were supposed to work in the first place, so I was unable to update them to get them to work with my changes. Because almost all of the other tests are working, I am fairly confident that the problem lies in the tests rather than in the changes I've made. I will need to figure this out and update, replace, or remove this test class, but I didn't want to block this PR on it.FIXME:
note about it in the code. This works for now... but should probably be fixed.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.