search

amazon-ion / ion-python

A Python implementation of Amazon Ion.
https://amazon-ion.github.io/ion-docs/
Apache License 2.0
261 stars 51 forks source link

pypy: Broken checks #377

Closed nirosys closed 1 month ago

nirosys commented 1 month ago

We have multiple checks failing due to rapidjson and ujson builds for pypy.

We're mostly interested in performance regressions for CPython, but definitely want to make sure the library functions under pypy. Right now all of our dependencies get installed with requirements.txt, even rapidjson and ujson which are only used during use of the benchmark cli.

If we split these dependencies out, and remove pypy from the benchmark tests, then we should be able to reduce the checks down to what we're interested in and not have any build failures due to native requirements that do not support pypy to begin with.

nirosys commented 1 month ago

More context: https://github.com/amazon-ion/ion-python/pull/376#issuecomment-2423109224

nirosys commented 1 month ago

Addressed with #378.