amazon-ion / ion-rust

Rust implementation of Amazon Ion
Apache License 2.0
147 stars 35 forks source link

Renames `ImmutableBuffer`/`TextBufferView` to `BinaryBuffer`/`TextBuffer` #831

Closed zslayton closed 3 weeks ago

zslayton commented 3 weeks ago

There are no logic changes in this PR, only mechanical renaming. It builds on #830.

ImmutableBuffer got its name because it stood in contrast to the (now removed) IonReader that mutated its state each time you advanced the cursor. Now that it stands alone, I think BinaryBuffer is more descriptive.

Similarly, TextBufferView was named that to emphasize that operations returned a new 'view' of the same buffer. However, the name does suggest that there's another TextBuffer that this is a view into. TextBuffer is (subjectively) less confusing and pairs nicely with BinaryBuffer.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.