search

amazon-ion / ion-schema-kotlin

A Kotlin reference implementation of the Ion Schema Specification.
https://amazon-ion.github.io/ion-schema/
Apache License 2.0
26 stars 14 forks source link

Update reader APIs #295

Closed popematt closed 1 year ago

popematt commented 1 year ago

Issue #, if available:

None

Description of changes:

Updates the reader APIs so that the user doesn't have to know the schema version ahead of time. Now the specific version is an implementation detail, and the user interacts with the reader by calling IonSchemaReader.readSchema().

Related PRs in ion-schema, ion-schema-tests, ion-schema-schemas:

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...n/ionschema/reader/internal/IonSchemaReaderV2_0.kt 88.13% <ø> (ø)
...schema/reader/internal/VersionedIonSchemaReader.kt 100.00% <100.00%> (ø)
...lin/com/amazon/ionschema/util/SchemaSymbolsUtil.kt 88.46% <100.00%> (ø)
...lin/com/amazon/ionschema/reader/IonSchemaReader.kt 0.00% <0.00%> (-100.00%) :arrow_down:

:loudspeaker: Thoughts on this report? Let us know!.