amazon-ion / ion-schema-rust

Rust implementation of Ion Schema
https://amazon-ion.github.io/ion-schema/sandbox
Apache License 2.0
13 stars 6 forks source link

adds implementation for `document` type #104

Closed desaikd closed 2 years ago

desaikd commented 2 years ago

Issue #103

Description of changes: This PR adds implementation of document type.

Ion Schema specification: https://amzn.github.io/ion-schema/docs/spec.html#type-system

document: represents a series of top-level values

List of changes:

Tests: adds unit tests for document type (removes previously unsupported tests from skip list)

desaikd commented 2 years ago

Suggested review changes:

popematt commented 2 years ago

Overall, this approach looks really good. Just a few minor questions/comments.