Closed desaikd closed 2 years ago
Suggested review changes:
document
type to an SExpressionIonSchemaElement
for validationIonSchemaElement
as inputIonSchemaElement
to use it for
violation messagesTypeStore
IonSchemaElement
enum variantOverall, this approach looks really good. Just a few minor questions/comments.
Issue #103
Description of changes: This PR adds implementation of
document
type.Ion Schema specification: https://amzn.github.io/ion-schema/docs/spec.html#type-system
List of changes:
IonSchemaElement
implementationTypeRef
validate method now usesIonSchemaElement
as inputTypeDefinitionImpl
'sparse_from_isl_type
method now returns aTypeId
instead ofTypeDefinitionImpl
nullable
annotation check for non built in type references to return an errordocument
type tests from skip listid()
forTypeRef
to get theTypeId
of thatTypeRef
Tests: adds unit tests for document type (removes previously unsupported tests from skip list)