Closed desaikd closed 1 year ago
Updates after last review:
IslTypeRefModifier
to NullabilityModifier
$null_or
modifier should not be allowed on a type reference that has
occurs
field in its definitionadds implementation of VariablyOccurringTypeRef
TypeDefinitionKind::get_occurs_constraint()
now that we have VariablyOccurringTypeRef
IslTypeRefImpl::get_occurs_constraint()
to return
Option<Range>
instead of bool
IslTypeRefImpl::get_occurs_constraint()
to
IslTypeRefImpl::get_occurs_range()
OccursConstraint
as it is treated as no-op
and is handled by VariablyOccurringTypeRef
Issue #164, #158
Description of changes:
This PR works on adding
$null_or
modifier support for ISL 2.0 and adds an implementation ofTypeReference
.List of changes:
IslTypeReferenceModifier
which stores modifier information for given type referencenullable_built_in_type_ref
and`null_or_named_type_ref
.nullable
modifier for ISL 1.0TypeReference
which stores type id and modifier information for givne type referenceTypeId
s to store type reference information$any
validate_for_base_nullable_type
to get the underlying ion type for a type definition$any
for ISL 2.0$null_or
modifierTypeDefinition
toTypeDefinitionKind
renames
TypeRef
toTypeDefinition
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.