Modifies `PartialEq` for `Violation` - Githubissues

amazon-ion / ion-schema-rust

Rust implementation of Ion Schema

https://amazon-ion.github.io/ion-schema/sandbox

Apache License 2.0

12 stars 6 forks source link

Modifies `PartialEq` for `Violation` #208

Closed desaikd closed 6 months ago

desaikd commented 6 months ago

Issue #206:

Description of changes:

This PR works on fixing PartialEq for Violation and modifies flattened_violations return sorted violations which can be used for comparison.

List of changes:

Changes PartialEq for Violation to defer to flattened violations for equivalence rather then Violations tree
Modified flattened_violations to return sorted vector absed on constraint
Modified flattened_violations to not return the violation itself when there are no children
adds clippy and rustfmt changes

Test:

Adds test for violations equivalence.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.