adds changes for `container_length` implementation - Githubissues

amazon-ion / ion-schema-rust

Rust implementation of Ion Schema

https://amazon-ion.github.io/ion-schema/sandbox

Apache License 2.0

13 stars 6 forks source link

adds changes for `container_length` implementation #67

Closed desaikd closed 2 years ago

desaikd commented 2 years ago

Issue #9 #10

Description of changes: This PR works on adding implementation of container_length constraint.

Grammar:

<CONTAINER_LENGTH> ::= container_length: <INT>
                     | container_length: <RANGE<INT>>

Ion Schema specification: https://amzn.github.io/ion-schema/docs/spec.html#container_length

List of changes:

adds IslConstraint::ContainerLength and Constraint::ContainerLength enum variants
adds IslLength that can be used by byte_length, codepoint_length and container_length constraints
fixes bug for non negative integer/integer ranges in occurs constraint
adds validation logic for container_length constraint in ContainerLengthConstraint implementation
adds ViolationCode::InvalidLength for any invalid length for constraints like codepoint_length, byte_length, container_length
adds unit tests for container_length constraint

Tests: added unit tests for container_length implementation.

adds tests for programmatically creating container_length constraint
adds tests for loading a schema using container_length constraint
adds validation tests for container_length constraint

desaikd commented 2 years ago

Changes with commit https://github.com/amzn/ion-schema-rust/pull/67/commits/1a811a9f7165c37222e958457dc38e885bffaeb2:

Removes implementation of both IslLength and IslOccurs
Uses Range directly to create container_length constraint programmatically
Uses usize for IntegerNonNegative Range
From<usize> implementation instead of TryFrom<AnyInt> for creating non negative integer ranges
optional() and required() methods now return Range instead of IonSchemaResult<Range> as these ranges will always be successfully created