adds changes for clippy fixes and suggestions - Githubissues

amazon-ion / ion-schema-rust

Rust implementation of Ion Schema

https://amazon-ion.github.io/ion-schema/sandbox

Apache License 2.0

13 stars 6 forks source link

adds changes for clippy fixes and suggestions #70

Closed desaikd closed 2 years ago

desaikd commented 2 years ago

Issue: #69

Description of changes: This PR works on adding all the changes suggested by Clippy (Rust linter).

Changes: The changes are incorporated in 3 separate commits:

Phase 1: clippy automated fixes for ion-schema crate
Phase 2: clippy automated changes for tests folder
Phase 3: manually added clippy suggestions
- uses ok_or_else instead of ok_or
- removes unnecessary collect() usage
- remove fn main() from doctests
- removes unnecessary lifetime usage
- uses assert! instead of assert_eq! for bool comparison
- uses if let instead of unwrap
- default() implementations for TypeStore and PendingTypes
- (Overridden clippy suggestion) uses self named constructors for Range
Bug Fix: while loading a schema tested as per a doc test in isl module