search

amazon-science / earth-forecasting-transformer

Official implementation of Earthformer
Apache License 2.0
349 stars 58 forks source link

fix(cuboid_transformer): Modified the argument order of '_generalize_padding' so that 'pad_h' comes before 'pad_w'. #48

Closed SungminLee0810 closed 1 year ago

SungminLee0810 commented 1 year ago

Issue:

In Line 280 of the PatchMerging3D class, the order of the pad_h and pad_w arguments in _generalize_padding is incorrect. AS-IS: x = _generalize_padding(x, pad_t, pad_w, pad_h, padding_type=self.padding_type) TO-BE: x = _generalize_padding(x, pad_t, pad_h, pad_w, padding_type=self.padding_type)

Description of changes:

The order of arguments in '_generalize_padding' has been modified so that pad_h comes before pad_w.

-- By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

gaozhihan commented 1 year ago

Thanks very much for your contribution!