amazon-science / video-contrastive-learning

Video Contrastive Learning with Global Context, ICCVW 2021
Apache License 2.0
156 stars 16 forks source link

In script shell/eval_retrieval.sh #8

Closed AllenPu closed 2 years ago

AllenPu commented 2 years ago

In line 34, is that should be python3 eval_retrieve_knn_pred.py instead of python3 eval_retrieval_knn_pred.py? It seems no file named eval_retrieval_knn_pred.py

AllenPu commented 2 years ago

and should be bash shell/eval_retrieve.sh?

KuangHaofei commented 2 years ago

Yes, it is! Sorry for the typo, we will fix it later! Thanks for your reminder!

bryanyzhu commented 2 years ago

Hi @KuangHaofei , just curious, will there be a PR to fix this? Thank you.

KuangHaofei commented 2 years ago

Sorry! I have submitted a new PR for the issue! Please check #10, thanks!

bryanyzhu commented 2 years ago

Thanks, just merged.