ambelovsky / koa-socket-2

Socket.IO for Koa
https://www.npmjs.com/package/koa-socket-2
98 stars 14 forks source link

Upgrade to socket.io v3 #22

Closed jojonas closed 3 years ago

jojonas commented 3 years ago

Apparently upgrading was easier than I thought. I cannot completely judge whether I caught all edge cases, but I went through the migration guide and searched for deprecated/replaced functions in the koa-socket-2 code. The tests run fine.

On a side node, I have replaced the deprecated istanbul code coverage tool with nyc, I hope that's okay.

Note that the changes are not backwards-compatible! Projects using koa-socket-2 and socket.io-client v2 will not work after the upgrade, without also upgrading the socket.io-client to v3! Therefore I changed the major version of koa-socket-2 to 2.

Fixes #21