Open Mte90 opened 2 months ago
I think that should be enough to check on https://github.com/Ph0enixKM/Amber/blob/69e96ae3867091bcd374ff3cf42909324e73646e/src/modules/expression/literal/status.rs#L28 if the command is unsafe to not print that
But if developer uses unsafe
modifier does this imply that they don't want to check the status
later on? @Mte90
I think this should be a part of rendered code optimisation for Amber
If the status is not used after why add code anyway? This is kind of a compiler optimization to generate only useful code.
So checking my experimental script to evaluate improvements to Amber https://github.com/Mte90/My-Scripts/blob/master/dev/lsp-installer/install.sh
We can see as today tons of __AS=$?
that are useless.
So https://github.com/amber-lang/amber/blob/master/src/modules/condition/failed.rs#L95 adds the useless variable.
I think that this code should check if the next line in the amber code is checking for the status
variable.
Maybe the approach should be the apposite looking at the code.
We add __AS=$?
basically at every command, instead when it is called status
we should add it the line before.
We can't do it on https://github.com/amber-lang/amber/blob/master/src/modules/expression/literal/status.rs#L30 as it is just a replace so how we can do that (I am saying just to understand how works)?
The solution that I came up with is recorded on this video: https://www.youtube.com/watch?v=_caXIMxrYj8 We could implement this optimization for this issue
So the amber script is:
Generate this bash script:
Create that variable also if not used is not helpful at all in the bash script generated. I think that if
unsafe
it is used that variable shouldn't be added.