search

amber-lang / amber

💎 Amber the programming language compiled to Bash
https://amber-lang.com
GNU General Public License v3.0
3.94k stars 89 forks source link

Remove compiled setup scripts from Git, use CI instead #462

Open mks-h opened 2 months ago

mks-h commented 2 months ago

Having both the source Amber files and the generated Bash files checked out in Git leads to inconsistency. For example see PR #457, which updates generated Bash files, as they were outdated.

Instead, lets set up a CI pipeline which will publish the generated Bash scripts at each release, and reference them in the installation instructions.

Mte90 commented 2 months ago

From the issue title do you mean that these amber scripts should be CI updated?

I agree but I think that we just need to recompile them at every new release inside the repository.

KrosFire commented 2 months ago

Committing obscure script that installs the software without approves is sus ngl ;)

We should compile add only via CI or/and check them in CI if they yield the same result

mks-h commented 2 months ago

@Mte90, I don't see a point in keeping compiled scripts in the repo. That can only lead to problems.

Ph0enixKM commented 2 months ago

I'm all in. This issue should have "sub issues" to update the install snippet on the website and documentation

Mte90 commented 2 months ago

@Mte90, I don't see a point in keeping compiled scripts in the repo. That can only lead to problems.

The install/uninstall scripts can't be in Amber, otherwise users how can they use them?

mks-h commented 2 months ago

Again, the idea is that the CI will compile Amber to Bash, and include it into the release.

Mte90 commented 2 months ago

So the Bash script will be in the release page? I am asking for this because usually that file is placed in the repository itself. Also it isn't updated so much often but we did some improvements in the last release.

mks-h commented 2 months ago

Yes, it will be in the releases. Placing it in the repo itself may make total sense for other projects, but only because they write it in Bash by hand. Our Bash scripts are just an artifact from the Amber files that are in the repo.

Mte90 commented 2 months ago

It is a pattern that I never saw honestly, could make sense but in the past we updated the installer also without doing a new release.

Mte90 commented 1 month ago

We have the CI but we will remove the files from the repo at the next release so we can update the docs.