search

amberframework / amber

A Crystal web framework that makes building applications fast, simple, and enjoyable. Get started with quick prototyping, less bugs, and blazing fast performance.
https://amberframework.org
MIT License
2.57k stars 205 forks source link

Missing build step #1272

Closed marccremer closed 2 years ago

marccremer commented 2 years ago

Description

If you try to build locally you need to run "shards install" before make else you get an error Missing shard.lock

Steps to Reproduce

  1. git clone git@github.com:amberframework/amber.git
  2. cd amber
  3. git checkout stable
  4. make

Expected behavior: If I follow the readme the project should build Actual behavior: I get an error Missing shard.lock

Reproduces how often: Always

Versions

Crystal 1.3.2 (2022-01-19)

LLVM: 13.0.0 Default target: x86_64-pc-linux-gnu arch linux

Additional Information

If you run shards install it works

crimson-knight commented 2 years ago

Can you make that change to the readme and submit a PR?

crimson-knight commented 2 years ago

Thanks, @marccremer for your PR, we've updated the build instructions to include the missing step. I've also created another PR that will update the stable branch for our Linux users to get the latest 1.2.2 version of Amber in #1285 but in the meantime you can build from master to get all of the latest updates.