Quality of life improvements

amberframework / amber

A Crystal web framework that makes building applications fast, simple, and enjoyable. Get started with quick prototyping, less bugs, and blazing fast performance.

https://amberframework.org

MIT License

2.57k stars 205 forks source link

Quality of life improvements #1292

Closed crimson-knight closed 1 year ago

crimson-knight commented 1 year ago

Description of the Change

Added github actions for CI instead of TravisCi
Updated ameba and improved the codebase to pass all ameba checks
Fixed a few failing tests for cookie functionality that relied on outdated crystal behavior
Changed the amber new command to check which node version a user has installed and adjust the node-sass sources based on the node version found
Bumped version from 1.2.1 to 1.3.0 because this is intended to be released so I can start creating content and publishing docs for the Amber community

Alternate Designs

Benefits

New Amber adopters will get a smoother experience when getting started using amber new

Possible Drawbacks

May impact pre 1.0.0 crystal users

drujensen commented 1 year ago

@crimson-knight Anyway to test this locally first? I'm getting a lot of emails asking for reviews.

crimson-knight commented 1 year ago

@drujensen sorry about that! As far as the GHA go, I haven't found a way to test that workflow locally. I did take a look at the test suite and it appears within that is where we are testing the different db adapters (mostly SQLite and PG). It looks like the tests that are failing on GHA are possibly related to differences in how CI runs the tests so I may have to configure this to use a docker image to run the actual tests to simulate a local env.

My local tests all pass, 480/480 now so I can merge this any time and stop email bombing you for a re-review :)

crimson-knight commented 1 year ago

@drujensen I have this at a satisfactory level for now. Github actions probably need a little more tweaking, but locally I get 480/480 tests passing, and some of these tweaks will help users on newer systems to use Amber smoothly.

I'd like to get this reviewed and cut a release today if possible.

crimson-knight commented 1 year ago

@robacarp can I get your review when you get a few minutes?