amberframework / amber

A Crystal web framework that makes building applications fast, simple, and enjoyable. Get started with quick prototyping, less bugs, and blazing fast performance.
https://amberframework.org
MIT License
2.57k stars 204 forks source link

amber 1.3.2 regression test failure against crystal 1.9.1 #1329

Closed chenrui333 closed 11 months ago

chenrui333 commented 11 months ago

Description

While building crystal 1.9.1, it was found that amber 1.3.2 test failed

  Postinstall of ameba: make bin && make run_file
  Failed postinstall of ameba on make bin && make run_file:
  /usr/local/bin/shards build 
  Dependencies are satisfied
  Building: ameba
  Error target ameba failed to compile:
  Showing last frame. Use --error-trace for full trace.

  There was a problem expanding macro 'macro_4732366672'

  Code in /usr/local/Cellar/crystal/1.9.1/share/crystal/src/yaml/serialization.cr:188:7

   188 | {% begin %}
         ^
  Called macro defined in /usr/local/Cellar/crystal/1.9.1/share/crystal/src/yaml/serialization.cr:188:7

   188 | {% begin %}

  Which expanded to:

     75 |                   
     76 | 
   > 77 |                   __temp_722 =
                            ^
  Error: type must be Ameba::Severity, not (Ameba::Severity | Nil)

  make: *** [bin/ameba] Error 1

Steps to Reproduce

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior: [What you expect to happen]

pass

Actual behavior: [What actually happens]

failed

Reproduces how often: [What percentage of the time does it reproduce?]

Additional Information

relates to https://github.com/Homebrew/homebrew-core/pull/136821

chenrui333 commented 11 months ago

cc @crimson-knight

Blacksmoke16 commented 11 months ago

This isn't related to Amber. See https://github.com/crystal-ameba/ameba/issues/372.

chenrui333 commented 11 months ago

@Blacksmoke16 thanks for the pointer, gonna try it now.

crimson-knight commented 11 months ago

I'm going to close this issue out since it's unrelated to Amber.

Thank you @chenrui333 for your hard work maintaining Homebrew!

chenrui333 commented 11 months ago

np at all, just propose some build patch to fix CI as well as brew build