search

amberframework / amber

A Crystal web framework that makes building applications fast, simple, and enjoyable. Get started with quick prototyping, less bugs, and blazing fast performance.
https://amberframework.org
MIT License
2.57k stars 204 forks source link

fix: patch to build with crystal 1.9.1 #1331

Closed chenrui333 closed 11 months ago

chenrui333 commented 11 months ago

closes #1329 relates to https://github.com/Homebrew/homebrew-core/pull/136915

cc @crimson-knight

chenrui333 commented 11 months ago

That would be great. I will close my associated homebrew one then. 💯

chenrui333 commented 11 months ago

@crimson-knight looks like there is a new crystal 1.9.2 release now, can you merge and make a release for amber? Thanks!!

chenrui333 commented 11 months ago

@crimson-knight gentle ping 🙏

crimson-knight commented 11 months ago

@chenrui333 thank you for the follow up, I should be able to get this fixed today. There's a couple of things I want to include in the new release. I was just delayed because I had a family member admitted to the hospital last week. It took some time but they will be ok now.

crimson-knight commented 11 months ago

I resolved this with another commit. I'll submit what is necessary for Homebrew shortly

chenrui333 commented 11 months ago

thanks, should be covered by this PR, https://github.com/Homebrew/homebrew-core/pull/138207

chenrui333 commented 11 months ago

btw, you can also automate the homebrew releases via either bump-homebrew-formula-action or action-homebrew-bump-formula. 😄