search

ambethia / recaptcha

ReCaptcha helpers for ruby apps
http://github.com/ambethia/recaptcha
MIT License
1.97k stars 440 forks source link

Use parameter `turbo` instead or `turbolinks` #433

Closed hjhart closed 11 months ago

hjhart commented 11 months ago

Turbolinks is no longer being actively developed. I've converted all uses of turbolinks in my app to turbo in doing the upgrade except for one.

Would y'all be willing to accept either turbo: true or turbolinks: true to support that? I think we could be backwards compatible to support both for some time while people migrate.

I'd be happy to submit a PR to close this issue out – I simply want to ensure that it would be considered for review.

Thanks!

grosser commented 11 months ago

👍 supporting both sounds good :)

hjhart commented 11 months ago

https://github.com/ambethia/recaptcha/pull/434 Here is the PR!

hjhart commented 11 months ago

Thanks for the quick release as well @grosser! This was released in version 5.16.0.