search

ambianic / ambianic-subscriptions

Repo for ambianic premium subscription management
Apache License 2.0
3 stars 2 forks source link

feat: splitting of ambianic-PWA functions into a separate repository #3

Closed vickywane closed 3 years ago

vickywane commented 3 years ago

This PR contains the basic serverless functions extracted from this PR and managed using Netlify functions for the user-management feature on the PWA.

commit-lint[bot] commented 3 years ago

Features

Bug Fixes

Contributors

ivelin, vickywane

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
ivelin commented 3 years ago

@vickywane where is the CI pipeline with local tests and staging tests before pushing live to production?

vickywane commented 3 years ago

Also, I don't see any postman test scripts in this PR.

The test scripts are the JSON collection file at tests/postman/*.json

ivelin commented 3 years ago

@vickywane I don't see any CI running on your PR originating fork: https://github.com/vickywane/ambianic-subscriptions

As mentioned before, your fork should have a full CI checklist that's at least at the level of or better than ambianic-ui a with 100% pass rate. Once that's accomplished, we can merge it in the main branch.

ivelin commented 3 years ago

@vickywane is this PR duplicate of #4 which I just merged?